-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: multi-miner & multi-signer scenario #5023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* assert that both stacks-nodes have same chain height, and that they produced blocks in each bitcoin block of nakamoto * signers are distributed as event observers across 2 stacks-nodes
ci change is fine, but i'll hold off approving until someone better suited evaluates the code changes. |
obycode
previously approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great
wileyj
previously approved these changes
Jul 30, 2024
…ustomize for mock_signing
kantai
force-pushed
the
test/multi-miner-signers
branch
from
July 31, 2024 18:21
f33d985
to
c50dff8
Compare
obycode
approved these changes
Jul 31, 2024
wileyj
approved these changes
Aug 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 1, 2024
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new testing scenario to the integration suite for
v0::signer
: setting up a multiple stacks-node network with 2 miners. The signer set's event listeners (and RPC invocations) are split between the two stacks-nodes.This test just produces bitcoin blocks and waits for block processing. It asserts that both nodes end the test with the same chain height and that they produced tenures in each bitcoin block in nakamoto.